Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FIRST_KEY_INDEX if a script accepts keys #2848

Closed
wants to merge 0 commits into from
Closed

Conversation

poiuj
Copy link

@poiuj poiuj commented Oct 6, 2024

Description

Setting FIRST_KEY_INDEX ensures we send the script to the right node, instead of sending to random node and repeating on getting MOVED repsonse. Relying on a random node send increases traffic and exceeds maxCommandRedirections configuration with non-zero probability.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? No need for documentation update.

@poiuj
Copy link
Author

poiuj commented Oct 21, 2024

Closed it by mistake. Opened a new one – #2858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant