Handle null tuple for redisearch document #2856
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, I updated to the latest version of RediSearch (2.10.7). I started getting a particular error that originates from within the redisearch library:
This error seems to have originated from this change. Instead of returning an empty array
[]
,None
is returned. The library does not handle this case, and so the error is thrown.This PR checks if the document is NULL, and if it is, return the object. This would give the same behavior as before.
I encountered this in the latest redis version (4.7). Not sure which branch I should be comitting to.
Checklist
npm test
pass with this change (including linting)?