fix: cast from db connections with non decoded output #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As stated on this issue, the connections objects may be set without decoding. Therefore, the stored hash can be a
bytes
object. This is an issue that clashes withschema_out_of_date
false positive: different type will force inequality checks to always beTrue
IndexMigration
expectsprevious_hash
to be ofstr
typeThis small check and reassignment for
stored_hash
, fixes the issue and enables correct detection.