docs(init): the warning and example for a dagger users #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr_Zavadkin <az@rees46.ru>
DanielGreenEngineer
previously approved these changes
Oct 21, 2024
TorinAsakura
approved these changes
Oct 22, 2024
TorinAsakura
requested changes
Oct 22, 2024
source/includes/_init.md.erb
Outdated
Comment on lines
174
to
175
| If your mobile application uses Dagger for dependency injection, make sure to keep the Dagger dependencies and the kapt plugin in your gradle files. | ||
| An example is provided in this documentation. If you are having trouble switching to version 2.0 of the Android SDK or newer, refer to the troubleshooting section in our guides. |
There was a problem hiding this comment.
а текст по параграфам раскидать внутри контейнера не нужно?
Signed-off-by: Aleksandr_Zavadkin <az@rees46.ru>
TorinAsakura
requested changes
Oct 24, 2024
| @@ -156,6 +170,14 @@ apply plugin: 'com.google.gms.google-services' | |||
|
|
|||
| Before using API you have to setup SDK. | |||
|
|
|||
| <aside class="warning"> | |||
| If your mobile application uses Dagger for dependency injection, make sure to keep the Dagger dependencies and the kapt plugin in your gradle files. | |||
There was a problem hiding this comment.
чо ты сделал? в p заверни блин
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rees46/planning/issues/1859
Пруф
Этот ПР не закрывает задачу, инструкция будет в подразделе "Решение проблем" в секции "Подключение". Здесь предупреждение, чтобы зависимости сходу не удаляли + пример.