feat: support PHP 8.4 (#34)

* test: add test for PHP 8.4

* run psalm only on highest dep

* bump phpstan & psalm

* fix implicit nullable

.github/workflows/php.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       matrix:
         operating-system: [ubuntu-latest]
-        php: [ '8.2', '8.3' ]
+        php: [ '8.2', '8.3', '8.4' ]
         symfony: [ '6.4.*', '7.*' ]
         dep: [highest,lowest]
 
@@ -54,6 +54,7 @@ jobs:
 
     - name: Run psalm
       run: make psalm
+      if: matrix.dep == 'highest'
 
     - name: Run phpstan
       run: make phpstan

CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.7.6
+
+* test: add test for PHP 8.4
+
 ## 0.7.5
 
 * deps: bump rekapager

composer.json

@@ -40,7 +40,7 @@
         "ekino/phpstan-banned-code": "^2.1",
         "fakerphp/faker": "^1.23",
         "pagerfanta/core": "^4.3",
-        "phpstan/phpstan": "^1.10.50",
+        "phpstan/phpstan": "^1.12",
         "phpstan/phpstan-deprecation-rules": "^1.1",
         "phpstan/phpstan-phpunit": "^1.3",
         "phpunit/phpunit": "^10.5",
@@ -69,7 +69,7 @@
         "symfony/web-profiler-bundle": "^6.4 || ^7.0",
         "symfony/yaml": "^6.4 || ^7.0",
         "twig/twig": "^3.8",
-        "vimeo/psalm": "^5.18",
+        "vimeo/psalm": "^5.26",
         "zenstruck/foundry": "1.37.*"
     },
     "autoload": {

src/Exception/NotFoundException.php

@@ -18,7 +18,7 @@
 #[WithHttpStatus(404)]
 class NotFoundException extends RuntimeException
 {
-    public function __construct(string $message = 'Not Found', \Throwable $previous = null)
+    public function __construct(string $message = 'Not Found', ?\Throwable $previous = null)
     {
         parent::__construct($message, 404, $previous);
     }

src/State/AbstractState.php

@@ -135,8 +135,11 @@ protected function isGranted(mixed $attribute, mixed $subject = null): bool
      *
      * @throws AccessDeniedException
      */
-    protected function denyAccessUnlessGranted(mixed $attribute, mixed $subject = null, string $message = 'Access Denied.'): void
-    {
+    protected function denyAccessUnlessGranted(
+        mixed $attribute,
+        mixed $subject = null,
+        string $message = 'Access Denied.'
+    ): void {
         if (!$this->isGranted($attribute, $subject)) {
             $exception = $this->createAccessDeniedException($message);
             $exception->setAttributes([$attribute]);
@@ -153,8 +156,10 @@ protected function denyAccessUnlessGranted(mixed $attribute, mixed $subject = nu
      *
      *     throw $this->createNotFoundException('Page not found!');
      */
-    protected function createNotFoundException(string $message = 'Not Found', \Throwable $previous = null): NotFoundException
-    {
+    protected function createNotFoundException(
+        string $message = 'Not Found',
+        ?\Throwable $previous = null
+    ): NotFoundException {
         return new NotFoundException($message, $previous);
     }
 
@@ -167,8 +172,10 @@ protected function createNotFoundException(string $message = 'Not Found', \Throw
      *
      * @throws \LogicException If the Security component is not available
      */
-    protected function createAccessDeniedException(string $message = 'Access Denied.', \Throwable $previous = null): AccessDeniedException
-    {
+    protected function createAccessDeniedException(
+        string $message = 'Access Denied.',
+        ?\Throwable $previous = null
+    ): AccessDeniedException {
         if (!class_exists(AccessDeniedException::class)) {
             throw new \LogicException('You cannot use the "createAccessDeniedException" method if the Security component is not available. Try running "composer require symfony/security-bundle".');
         }