fix: batch size CLI option

rekalogika · Jul 17, 2024 · 4e94736 · 4e94736
1 parent abfa174
commit 4e94736
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/rekapager-symfony-bridge/src/Batch/BatchCommand.php b/packages/rekapager-symfony-bridge/src/Batch/BatchCommand.php
@@ -49,7 +49,7 @@ public function __construct()
         parent::__construct();
 
         $this->addOption('resume', 'r', InputOption::VALUE_OPTIONAL, 'Page identifier to resume from');
-        $this->addOption('pagesize', 'p', InputOption::VALUE_OPTIONAL, 'Batch/page/chunk size');
+        $this->addOption('page-size', 'p', InputOption::VALUE_OPTIONAL, 'Batch/page/chunk size');
         $this->addOption('progress-file', 'f', InputOption::VALUE_OPTIONAL, 'Temporary file to store progress data');
         $this->addOption('time-limit', 't', InputOption::VALUE_OPTIONAL, 'Runs the batch up to the specified time limit (in seconds)');
     }
@@ -79,7 +79,7 @@ final protected function execute(InputInterface $input, OutputInterface $output)
         // input checking
 
         $resume = $input->getOption('resume');
-        $pageSize = $input->getOption('pagesize');
+        $pageSize = $input->getOption('page-size');
         $progressFile = $input->getOption('progress-file');
         $timeLimit = $input->getOption('time-limit');
 
@@ -89,7 +89,7 @@ final protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         if (!is_numeric($pageSize) && $pageSize !== null) {
-            throw new InvalidArgumentException('Invalid pagesize option');
+            throw new InvalidArgumentException('Invalid page-size option');
         }
 
         if ($pageSize !== null) {

diff --git a/tests/src/App/Command/AppSimpleBatchCommand.php b/tests/src/App/Command/AppSimpleBatchCommand.php
@@ -42,8 +42,10 @@ public function __construct(
         parent::__construct();
     }
 
-    protected function getPageable(InputInterface $input, OutputInterface $output): PageableInterface
-    {
+    protected function getPageable(
+        InputInterface $input,
+        OutputInterface $output
+    ): PageableInterface {
         $adapter = new SelectableAdapter($this->postRepository);
 
         return new KeysetPageable($adapter);