Skip to content

Commit

Permalink
Speedup for G1 in other curves.
Browse files Browse the repository at this point in the history
  • Loading branch information
@dfaranha
dfaranha committed Aug 12, 2024
1 parent c8f9731 commit 6cd3777
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 45 deletions.
57 changes: 33 additions & 24 deletions src/epx/relic_ep4_mul.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,58 +82,65 @@ static void ep4_psi(ep4_t r, const ep4_t p) {

#if EP_MUL == LWNAF || !defined(STRIP)

static void ep4_mul_glv_imp(ep4_t r, const ep4_t p, const bn_t k) {
static void ep4_mul_gls_imp(ep4_t r, const ep4_t p, const bn_t k) {
size_t l, _l[8];
bn_t n, _k[8], u;
int8_t naf[8][RLC_FP_BITS + 1];
ep4_t q[8];
ep4_t q, t[8][1 << (RLC_WIDTH - 2)];

bn_null(n);
bn_null(u);
ep4_null(q);

RLC_TRY {
bn_new(n);
bn_new(u);
for (int i = 0; i < 8; i++) {
ep4_new(q);
for (size_t i = 0; i < 8; i++) {
bn_null(_k[i]);
ep4_null(q[i]);
bn_new(_k[i]);
ep4_new(q[i]);
for (size_t j = 0; j < (1 << (RLC_WIDTH - 2)); j++) {
ep4_null(t[i][j]);
ep4_new(t[i][j]);
}
}

ep4_curve_get_ord(n);
fp_prime_get_par(u);
bn_mod(_k[0], k, n);
bn_rec_frb(_k, 8, _k[0], u, n, ep_curve_is_pairf() == EP_BN);

ep4_norm(q[0], p);
for (size_t i = 1; i < 8; i++) {
ep4_psi(q[i], q[i - 1]);
}
#if defined(EP_MIXED)
ep4_norm_sim(q + 1, q + 1, 7);
#endif

l = 0;
for (size_t i = 0; i < 8; i++) {
if (bn_sign(_k[i]) == RLC_NEG) {
ep4_neg(q[i], q[i]);
}
_l[i] = RLC_FP_BITS + 1;
bn_rec_naf(naf[i], &_l[i], _k[i], 2);
bn_rec_naf(naf[i], &_l[i], _k[i], RLC_WIDTH);
l = RLC_MAX(l, _l[i]);
if (i == 0) {
ep4_norm(q, p);
if (bn_sign(_k[0]) == RLC_NEG) {
ep4_neg(q, q);
}
ep4_tab(t[0], q, RLC_WIDTH);
} else {
for (size_t j = 0; j < (1 << (RLC_WIDTH - 2)); j++) {
ep4_frb(t[i][j], t[i - 1][j], 1);
if (bn_sign(_k[i]) != bn_sign(_k[i - 1])) {
ep4_neg(t[i][j], t[i][j]);
}
}
}
}

ep4_set_infty(r);
for (int j = l - 1; j >= 0; j--) {
ep4_dbl(r, r);

for (int i = 0; i < 8; i++) {
for (size_t i = 0; i < 8; i++) {
if (naf[i][j] > 0) {
ep4_add(r, r, q[i]);
ep4_add(r, r, t[i][naf[i][j] / 2]);
}
if (naf[i][j] < 0) {
ep4_sub(r, r, q[i]);
ep4_sub(r, r, t[i][-naf[i][j] / 2]);
}
}
}
Expand All @@ -147,11 +154,13 @@ static void ep4_mul_glv_imp(ep4_t r, const ep4_t p, const bn_t k) {
RLC_FINALLY {
bn_free(n);
bn_free(u);
for (int i = 0; i < 8; i++) {
ep4_free(q);
for (size_t i = 0; i < 8; i++) {
bn_free(_k[i]);
ep4_free(q[i]);
for (size_t j = 0; j < (1 << (RLC_WIDTH - 2)); j++) {
ep4_free(t[i][j]);
}
}

}
}

Expand Down Expand Up @@ -647,7 +656,7 @@ void ep4_mul_lwnaf(ep4_t r, const ep4_t p, const bn_t k) {

#if defined(EP_ENDOM)
if (ep_curve_is_endom()) {
ep4_mul_glv_imp(r, p, k);
ep4_mul_gls_imp(r, p, k);
return;
}
#endif
Expand Down
53 changes: 33 additions & 20 deletions src/epx/relic_ep8_mul.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,55 +40,65 @@

#if EP_MUL == LWNAF || !defined(STRIP)

static void ep8_mul_glv_imp(ep8_t r, const ep8_t p, const bn_t k) {
static void ep8_mul_gls_imp(ep8_t r, const ep8_t p, const bn_t k) {
size_t l, _l[16];
bn_t n, _k[16], u;
int8_t naf[16][RLC_FP_BITS + 1];
ep8_t q[16];
ep8_t q, t[16][1 << (RLC_WIDTH - 2)];

bn_null(n);
bn_null(u);
ep8_null(q);

RLC_TRY {
bn_new(n);
bn_new(u);
for (int i = 0; i < 16; i++) {
ep8_new(q);
for (size_t i = 0; i < 16; i++) {
bn_null(_k[i]);
ep8_null(q[i]);
bn_new(_k[i]);
ep8_new(q[i]);
for (size_t j = 0; j < (1 << (RLC_WIDTH - 2)); j++) {
ep8_null(t[i][j]);
ep8_new(t[i][j]);
}
}

ep8_curve_get_ord(n);
fp_prime_get_par(u);
bn_mod(_k[0], k, n);
bn_rec_frb(_k, 16, _k[0], u, n, ep_curve_is_pairf() == EP_BN);

ep8_norm(q[0], p);
for (size_t i = 1; i < 16; i++) {
ep8_frb(q[i], q[i - 1], 1);
}

l = 0;
for (size_t i = 0; i < 16; i++) {
if (bn_sign(_k[i]) == RLC_NEG) {
ep8_neg(q[i], q[i]);
}
_l[i] = RLC_FP_BITS + 1;
bn_rec_naf(naf[i], &_l[i], _k[i], 2);
bn_rec_naf(naf[i], &_l[i], _k[i], RLC_WIDTH);
l = RLC_MAX(l, _l[i]);
if (i == 0) {
ep8_norm(q, p);
if (bn_sign(_k[0]) == RLC_NEG) {
ep8_neg(q, q);
}
ep8_tab(t[0], q, RLC_WIDTH);
} else {
for (size_t j = 0; j < (1 << (RLC_WIDTH - 2)); j++) {
ep8_frb(t[i][j], t[i - 1][j], 1);
if (bn_sign(_k[i]) != bn_sign(_k[i - 1])) {
ep8_neg(t[i][j], t[i][j]);
}
}
}
}

ep8_set_infty(r);
for (int j = l - 1; j >= 0; j--) {
ep8_dbl(r, r);

for (int i = 0; i < 16; i++) {
for (size_t i = 0; i < 16; i++) {
if (naf[i][j] > 0) {
ep8_add(r, r, q[i]);
ep8_add(r, r, t[i][naf[i][j] / 2]);
}
if (naf[i][j] < 0) {
ep8_sub(r, r, q[i]);
ep8_sub(r, r, t[i][-naf[i][j] / 2]);
}
}
}
Expand All @@ -102,9 +112,12 @@ static void ep8_mul_glv_imp(ep8_t r, const ep8_t p, const bn_t k) {
RLC_FINALLY {
bn_free(n);
bn_free(u);
for (int i = 0; i < 16; i++) {
ep8_free(q);
for (size_t i = 0; i < 16; i++) {
bn_free(_k[i]);
ep8_free(q[i]);
for (size_t j = 0; j < (1 << (RLC_WIDTH - 2)); j++) {
ep8_free(t[i][j]);
}
}
}
}
Expand Down Expand Up @@ -595,7 +608,7 @@ void ep8_mul_lwnaf(ep8_t r, const ep8_t p, const bn_t k) {

#if defined(EP_ENDOM)
if (ep_curve_is_endom()) {
ep8_mul_glv_imp(r, p, k);
ep8_mul_gls_imp(r, p, k);
return;
}
#endif
Expand Down
2 changes: 1 addition & 1 deletion src/low/x64-asm-8l/relic_bn_mul_low.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void bn_muln_low(dig_t *c, const dig_t *a, const dig_t *b, size_t size) {
}

void bn_muld_low(dig_t *c, const dig_t *a, size_t sa, const dig_t *b, size_t sb,
int low, int high) {
uint_t low, uint_t high) {
(void)low;
(void)high;
mpn_mul(c, a, sa, b, sb);
Expand Down

0 comments on commit 6cd3777

Please sign in to comment.