Security updates from npm audit fix; shouldn't be any breaking changes #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite should catch any issues, but a quick smoke test in a real app never hurts. The node 16 suite is currently failing for this PR. And I guess we should add current LTS (20.0) and perhaps 18 (still widely used) to the matrix. |
|
Smoke test completed, using Notes Together and nodeJS v16.20.2 on MacOS 14.0. The earlier failure of the test suite was a timeout, which did not happen on a re-run. As for nodeJS v18, both the Jaribu and Mocha tests fail with "ReferenceError: FileReader is not defined", so that will have to wait. Also note Jaribu is no longer supported |
raucao
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all packages here are using semantic versioning properly, there shouldn't be any breaking changes. Do we need any testing beyond the existing testing suite?