Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node.js 18, 20 #1313

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Support node.js 18, 20 #1313

merged 9 commits into from
Jun 17, 2024

Conversation

raucao
Copy link
Member

@raucao raucao commented Jun 16, 2024 •
edited
Loading

See commits for details.

fixes #1300, fixes #1308, refs #1270

@raucao
Copy link
Member Author

raucao commented Jun 16, 2024

The next step is fixing the documentation dependency hell, which also requires us to use --force for npm installs currently. I think I'll have a go at converting everything to Markdown, and then trying to get as close as possible to the current docs using VitePress and https://www.typedoc-plugin-markdown.org/plugins/vitepress, so we can ditch the whole Python/Sphinx setup entirely and use the latest versions of typedoc and typescript.

DougReeder
DougReeder approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@DougReeder DougReeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all good changes to modernize the code.

@raucao raucao merged commit 9999f23 into master Jun 17, 2024
2 of 3 checks passed
@raucao raucao deleted the chore/node-20 branch June 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougReeder DougReeder DougReeder approved these changes

@silverbucket silverbucket Awaiting requested review from silverbucket

@galfert galfert Awaiting requested review from galfert

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jaribu test failing in CI for node 16 Tests fail under NodeJS v18
2 participants
@raucao @DougReeder