Support SDK installation from command-line #65
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is absolutely a step in the right direction but I feel like we should also be able to just use an env variable for the SDK path. I develop for other android engines; why do I need a separate SDK directory just for ren'py? |
|
You don't need separate android SDK, just create symlink for SDK folder after installing rapt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, there is no command-only way to install the SDK from the command-line, which is an issue when automating Ren'Py games' releases as it makes it impossible to 'cleanly' automate Android releases on CI/CD platforms.
This PR:
buildlibpath when running from a directory that is not the one that containsandroid.pylib/py?-[...]/python -m rapt.androidfrom Ren'Py's directory to install the android SDK from the command-line on a Ren'Py install