Skip to content
This repository has been archived by the owner on Jun 15, 2020. It is now read-only.

build(deps): bump victory from 30.6.1 to 34.3.11 #491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps victory from 30.6.1 to 34.3.11.

Release notes

Sourced from victory's releases.

v33.0.0

Breaking Changes

Changes for functional props and styles:

Related PR: #1360

Functional props like labels and functional styles will now be called with a single argument instead of datum and active. The argument passed to functional props and styles will be an object containing all the props that control the rendering of the the target the prop applies to. Including things like datum, active, index, data, scale, etc. We hope this will give users a lot more flexibility and control. In most cases, this change should be very straightforward to apply

old:

labels={(d) => `x: ${d.x}`}

new

labels={({ datum }) => `x: ${d.x}`}

Gotchas:

  • Some of the props passed into functional props and styles may themselves be functions. These will not be evaluated, because we have no way to determine evaluation order. So, if you create a cornerRadius function that depends on barWidth, do not also make barWidth a function of some other prop.
  • A few props that take functions do not follow this pattern. These include data accessor functions like y and x, and tickFormat. The arguments for these props have not changed.

Changes for VictoryCandlestick labels

Related PR: #1295

VictoryCandlestick now has granular support for labels corresponding to each portion of the candle. The current labels and labelComponent props will be joined by new props corresponding to each part of the candle. New props lowLabels lowLabelComponent highLabels highLabelComponent openLabels openLabelComponent closeLabels closeLabelComponent

This will be a breaking change affecting the positioning of the default label. In earlier versions, the default label was positioned above the candle, it will now be positioned next to the center of the candle. To use older label positioning, use highLabels / highLabelComponent rather than label / labelComponent. If you are using tooltips with VictoryCandlestick, you will need to register a custom event to trigger your highLabels tooltip:

example:

<VictoryCandlestick
  highLabels={({ datum }) => datum.high}
  highLabelComponent={<VictoryTooltip />}
  events={[{
    target: "data",
    eventHandlers: {
      onMouseOver: () => ({ target: "highLabels", mutation: () => ({ active: true }) }),
</tr></table> ... (truncated)
Changelog

Sourced from victory's changelog.

34.3.11 (2020-06-09)

  • #1605 - Fixes padding for axes with non-standard orientations. Thanks @glvnsky!

34.3.10 (2020-06-07)

  • #1604 - Fixes offsets for groups of stacked bars. Thanks @cneltyn!

  • #1599 - Fixes a bug causing incorrect cursor behavior onMouseLeave. Thanks @NgoKnows!

34.3.9 (2020-05-30)

  • #1592 - Cache sharedEvents to improve performance in evented containers. Thanks @NgoKnows!

34.3.8 (2020-05-26)

  • #1588 - Improve perfomance by reducing string map calculations. Thanks @NgoKnows!

34.3.7 (2020-05-22)

  • #1576 - Add more types for primitive components. Thanks @maddles

34.3.6 (2020-05-18)

  • #1580 - Improve histogram tooltip positioning for VictoryVoronoiContainer
  • #1581 - Prevent VictoryVoronoiContainer from rendering tooltips with empty text

34.3.5 (2020-05-15)

-#1575 - Allow the id prop for VictoryLabel to be given as a function. Thanks @amyboyd!

34.3.4 (2020-05-14)

  • #1573 - Add explicit dependencies on d3-scale and react-fast-compare for victory-histogram. Thanks @Mike-Dax!

34.3.3 (2020-05-13)

  • #1572 - Add missing backgroundComponent type

34.3.2 (2020-05-13)

  • #1570 - Correct missing victory-histogram dependency

34.3.1 (2020-05-13)

  • #1568 - Correct export for VictoryHistogram

34.3.0 (2020-05-12)

... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants