This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Addressing potential connection leaks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing potential **connection leak** issues caused by connections not being `close()`'ed properly inside a `run` handler function. For instance: if an error is thrown or the callback function screws up, the connection object would then be left opened till who-knows-how-long. I'm not entirely sure if my hypothesis is correct though, so please fix me if I'm wrong. Thank you!
|
/cc @deontologician |
|
@Thesephi I'll check this out soon, thanks for the PR! |
|
@deontologician no prob! We were building an app on top of this example, and in the process we noticed this bit. Our rethinkdb log was full of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing potential connection leak issues caused by connections not being
close()'ed properly inside arunhandler function. For instance: if an error is thrown or the callback function screws up, the connection object would then be left opened till who-knows-how-long.I'm not entirely sure if my hypothesis is correct though, so please fix me if I'm wrong. Thank you!