-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes to the Java driver #7
Conversation
|
…com/rethinkdb/rethinkdb-java into develop/experimental � Conflicts: � Makefile � build.gradle � src/main/java/com/rethinkdb/RethinkDB.java � src/main/java/com/rethinkdb/net/Util.java
Reactive streams was dropped due to their |
rethinkdb/rethinkdb#4101 implemented on commits |
This PR tracks experimental changes for the official rethinkdb-java driver.
Implemented changes
json-simple
with Jacksonjava.util.Optional
usage with@Nullable
annotationsUtil.toReqlAst()
wrongly resetting the remaining depth.TypeReference<T>
onReqlAst.run()
ReqlAst.runAsync()
: Asynchronous resultReqlAst.toString()
pretty-prints the ASTMapObject
DefaultConnectionFactory
Connection.noreplyWaitAsync()
: Asynchronous noreplyWaitConnection.server()
and async variance (Implements Add server_info() command #14)Cursor
was deleted and replaced withResult
ReqlAsr.run()
always returnsResult<T>
, which covers all result types and implementsIterator<T>
andIterable<T>
toList()
,collect()
,stream()
,parallelStream()
methodsResult<List<T>>
is unwrapped toResult<T>
)r.pathspec(...)
(Implements Implement r.pathspec(...) #16)Util.toReqlAst()
now properly serializes primitive arrays and other Collections as well.Partially implemented
CoerceType
Notes
Code which use Connection, Cursor and the old dynamic return type of
.run
breaks, but those classes got full documentation of the new usage.All tests doesn't compile. Root tests may need manual rewrite while Generated tests need Python scripts need rewrite to generate new valid tests.Tests now compile by patching TestingCommon to generate expected behaviour.