-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change product name to fix Discord status conflict #131
base: master
Are you sure you want to change the base?
Conversation
I personally would vote for this change. As other's have said this is a Discord issue, but there's basically a 0% chance that Discord will fix this. This is a simple change Revolt can make to bypass this Discord bug. I personally don't keep Revolt open simply because I don't want this faulty Discord status. I would assume other's do the same. Some people are going to slowly transition from Discord to Revolt and Imo this is a simple cleanup solution. It seems others have had success changing the .exe file name, but I don't think this is possible for everyone. I'm on Windows 10 and installed Revolt through the app store. The app is installed in |
it's been over 3mo since this PR opened and idfk why it hasn't been merged yet /shrug |
You asked for it, so here are a couple of potential answers.
So, instead of trying to **** the shit out of this binary & leave it to rot in some hidden alley at the back of an Alabama building, the name should stay the same, or the newly proposed name should keep the elegance by for example shortening it to Shit on Discord btw. Stop using it, altogether! |
There is no need for this amount of toxicity. Actually, any toxicity. @theAkito So I'll answer your comment in a manner that somewhat matches you.
|
I've checked AppImage's and they are unaffected by pipelines.
|
Latest commit also just does a rebase from |
bumping |
Required tests:
I can personally test these in 1.5 weeks unless if someone else wants to pick it up (don't have a Windows or macOS machine on me). |
@insertish It has been tested on Windows (Installer and AppX) and Linux (AppImage and Flatpak) already with no issues when I tested it ~3mo ago and when I last updated this PR. |
Does it retain the 'Revolt' name on the actual application and in places like the start/application menu? That was my only concern there which was a bit non-obvious from the PR description. |
@insertish It does not retain the name in the shortcuts as |
Is there any way to avoid that? |
Bump. I do not want to change our branding just to accommodate for another platform. |
Please make sure to check the following tasks before opening and submitting a PR
note: This PR replaces my previous one, #121
Changed property
productName
andbuild.appx.displayName
inpackage.json
to fix Discord Status, which then changes the Windows Executable toRevolt Desktop.exe
instead ofRevolt.exe
to not get confused with the game Re-Volt.Tested and working;
Revolt
toRevolt Desktop
Revolt Desktop-
instead ofRevolt-
.package.name
instead ofpackage.productName