Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amundsenfrontend changes initial commit #1

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
2 changes: 1 addition & 1 deletion docker-amundsen-local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ services:
- amundsenmetadata
- amundsensearch
ports:
- 5000:5000
- 8000:5000 # Port set to 8000 because in macOS Monterey 5000 is taken
networks:
- amundsennet
environment:
Expand Down
Empty file modified example/docker/neo4j/conf/neo4j.conf
100644 → 100755
Empty file.
5 changes: 4 additions & 1 deletion frontend/amundsen_application/api/utils/metadata_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ def marshall_table_full(table_dict: Dict) -> Dict:
table: Table = schema.load(table_dict)
results: Dict[str, Any] = schema.dump(table)

is_editable = is_table_editable(results['schema'], results['name'])
# is_editable = is_table_editable(results['schema'], results['name'])
# Forcing to False since we don't want to allow the users to update
# any parameters through the UI
is_editable = False
results['is_editable'] = is_editable

# TODO - Cleanup https://github.com/lyft/amundsen/issues/296
Expand Down
20 changes: 18 additions & 2 deletions frontend/amundsen_application/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Config:

# DEPRECATED (since version 3.9.0): Please use `POPULAR_RESOURCES_COUNT`
# Number of popular tables to be displayed on the index/search page
POPULAR_TABLE_COUNT = None
POPULAR_TABLE_COUNT = 10
POPULAR_RESOURCES_COUNT = 4 # type: int

# DEPRECATED (since version 3.9.0): Please use `POPULAR_RESOURCES_PERSONALIZATION`
Expand Down Expand Up @@ -107,7 +107,23 @@ class Config:
ISSUE_TRACKER_ISSUE_TYPE_ID = None

# Programmatic Description configuration. Please see docs/flask_config.md
PROGRAMMATIC_DISPLAY = None # type: Optional[Dict]
PROGRAMMATIC_DISPLAY = {
"RIGHT": {
"primary_keys": {"display_order": 0},
"service_level_agreement": {"display_order": 1},
"view_location": {"display_order": 2},
},
"LEFT": {
"data_owner": {"display_order": 0},
"ETL Frequency (Last 7 Days)": {"display_order": 1},
},
"related_objects": {"display_order": 0},
"source_type": {"display_order": 1},
"connection": {"display_order": 2},
"replication_strategy": {"display_order": 3},
"source_code": {"display_order": 4},
"post_process": {"display_order": 5},
}

# If specified, will be used to generate headers for service-to-service communication
# Please note that if specified, this will ignore following config properties:
Expand Down
10 changes: 5 additions & 5 deletions frontend/amundsen_application/static/.betterer.results
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,9 @@ exports[`eslint`] = {
"js/components/Tags/index.tsx:3468508233": [
[38, 4, 21, "Must use destructuring props assignment", "4236634811"]
],
"js/config/config-default.ts:429062513": [
[366, 6, 21, "\'partitionKey\' is defined but never used.", "399589312"],
[367, 6, 23, "\'partitionValue\' is defined but never used.", "793372348"]
"js/config/config-default.ts:2446070824": [
[378, 6, 21, "\'partitionKey\' is defined but never used.", "399589312"],
[379, 6, 23, "\'partitionValue\' is defined but never used.", "793372348"]
],
"js/ducks/announcements/index.spec.ts:1898496537": [
[3, 0, 148, "\`.\` import should occur after import of \`./types\`", "4154971894"]
Expand Down Expand Up @@ -634,8 +634,8 @@ exports[`eslint`] = {
[199, 21, 20, "Must use destructuring state assignment", "2976153148"],
[201, 26, 21, "Must use destructuring props assignment", "2163940102"]
],
"js/pages/TableDetailPage/ExploreButton/index.tsx:1031745331": [
[13, 0, 454, "Component should be written as a pure function", "1437366564"],
"js/pages/TableDetailPage/ExploreButton/index.tsx:875794805": [
[13, 0, 458, "Component should be written as a pure function", "2665503074"],
[15, 35, 20, "Must use destructuring props assignment", "2510284131"]
],
"js/pages/TableDetailPage/FrequentUsers/index.tsx:14585253": [
Expand Down
16 changes: 8 additions & 8 deletions frontend/amundsen_application/static/.storybook/amundsenTheme.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,27 @@ import { create } from '@storybook/theming/create';
export default create({
base: 'light',

colorPrimary: '#9c9bff', // indigo30
colorSecondary: '#665aff', // indigo60
colorPrimary: '#007DFB', // revlightblue
colorSecondary: '#0666EB', // revblue

// UI
appBg: '#fcfcff', // gray0
appContentBg: '#cacad9', // gray20
appBorderColor: '#63637b', // gray60
appContentBg: '#DEE2E7', // revgrey2
appBorderColor: '#4E5867', // revgrey6
appBorderRadius: 4,

// Typography
fontBase: '"Open Sans", sans-serif',
fontCode: '"Menlo-Bold", monospace',

// Text colors
textColor: '#292936', // gray100
textColor: '#21262E', // revblack
textInverseColor: '#fcfcff', // gray0

// Toolbar default and active colors
barTextColor: '#dcdcff', // indigo10
barSelectedColor: '#292936', // gray100
barBg: '#665aff', // indigo60
barTextColor: '#6DCFFC', // revskyblue2
barSelectedColor: '#21262E', // revblack
barBg: '#0666EB', // revblue

// Form colors
inputBg: 'white',
Expand Down
31 changes: 31 additions & 0 deletions frontend/amundsen_application/static/css/_colors.scss
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,34 @@ $gray70: #515167;
$gray80: #414155;
$gray90: #334;
$gray100: #292936;

/* Revolut Core Palette */
$revwhite: #FFFFFF;
$revblack: #21262E;
$revblue: #0666EB;

/* Revolut Greyscale Palette */
$revgrey1: #F5F6F8;
$revgrey2: #DEE2E7;
$revgrey3: #BCC3CE;
$revgrey4: #99A2AF;
$revgrey5: #6F7988;
$revgrey6: #4E5867;
$revgrey7: #333B47;

/* Revolut Extended Palette */
$revlightblue: #007DFB;
$revskyblue: #00ABFA;
$revteal: #00BE90;
$revgreen: #6DB720;
$revyellow: #FBC70A;
$revorange: #F7930D;
$revterracotta: #EE7A40;
$revred: #F54C3E;
$revpink: #ED5B7B;
$revpurple: #C054D3;
$revdeeppurple: #805CF5;

/* Revolut Custom Extended Palette */
$revskyblue1: #B6E7FD;
$revskyblue2: #6DCFFC;
4 changes: 4 additions & 0 deletions frontend/amundsen_application/static/css/_icons-custom.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

// This file is intentionally left blank and should be used to add new icons or overwrite defaults from _icons-default.scss
$data-stores: (
exasol: '../images/icons/exasol_logo.png',
helios: '../images/icons/exasol_logo.png',
);
72 changes: 72 additions & 0 deletions frontend/amundsen_application/static/css/_variables-custom.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,75 @@
// SPDX-License-Identifier: Apache-2.0

// This file is intentionally left blank and should be used to add new custom variables or overwrite defaults from _variables-default.scss
$brand-color-1: $revskyblue1;
$brand-color-2: $revskyblue2;
$brand-color-3: $revskyblue;
$brand-color-4: $revlightblue;
$brand-color-5: $revblue;

$divider: $revgrey2;
$stroke: $revgrey3;
$stroke-light: $revgrey2;
$stroke-focus: $revgrey6;
$stroke-underline: $revgrey4;

/* Scaffolding */
$body-bg: $revwhite;
$body-bg-secondary: $gray0;
$body-bg-tertiary: $revgrey1;
$body-bg-dark: $revblack;
$divider: $revgrey2;
$stroke: $revgrey3;
$stroke-light: $revgrey2;
$stroke-focus: $revgrey6;
$stroke-underline: $revgrey4;

// Typography
$text-primary: $revblack;
$text-secondary: $revgrey6;
$text-tertiary: $revgrey4;
$text-placeholder: $revgrey4;

$column-name-color: $revblue;
$link-color: $revlightblue;
$link-hover-color: $revblue;

// Buttons
$btn-primary-bg: $revlightblue;
$btn-primary-bg-hover: $revblue;
$btn-primary-border: transparent;
$btn-primary-border-hover: transparent;
$btn-primary-color: $revwhite;
$btn-primary-color-hover: $revwhite;

$btn-default-border: $revgrey2;
$btn-default-border-hover: $revgrey4;
$btn-default-color: $revblack;
$btn-default-color-hover: $revgrey7;

// Icons
$icon-bg: $revgrey2;
$icon-bg-brand: $revskyblue;
$icon-bg-dark: $revgrey6;
$icon-bg-disabled: $revgrey2;

// Header, Body, & Footer
$nav-bar-color: $revblack;

// Badges
$badge-text-color: $revblack;
$badge-negative-color: $revorange;
$badge-neutral-color: $revgrey3;
$badge-primary-color: $revteal;
$badge-positive-color: $revgreen;
$badge-warning-color: $revred;
$badge-overlay: $revblack;

// Tags
$tag-bg: $revgrey2;
$tag-bg-hover: $revgrey4;
$resource-title-color: $revlightblue;

// Priority
$priority-text-blocker: $white;
$priority-bg-color: $revred;
30 changes: 15 additions & 15 deletions frontend/amundsen_application/static/css/_variables-default.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ $text-tertiary: $gray40 !default;
$text-placeholder: $gray40 !default;
$text-inverse: $white !default;

$column-name-color: $indigo70;
$link-color: $brand-color-4;
$link-hover-color: $brand-color-5;
$column-name-color: $indigo70 !default;
$link-color: $brand-color-4 !default;
$link-hover-color: $brand-color-5 !default;

$font-family-body: 'Open Sans', sans-serif !default;
$font-weight-body-regular: 400 !default;
Expand All @@ -54,12 +54,12 @@ $line-height-small: 1.5 !default;
$line-height-large: 1.5 !default;

// Badges
$badge-text-color: $text-primary;
$badge-negative-color: $sunset20;
$badge-neutral-color: $gray20;
$badge-primary-color: $cyan10;
$badge-positive-color: $mint20;
$badge-warning-color: $amber30;
$badge-text-color: $text-primary !default;
$badge-negative-color: $sunset20 !default;
$badge-neutral-color: $gray20 !default;
$badge-primary-color: $cyan10 !default;
$badge-positive-color: $mint20 !default;
$badge-warning-color: $amber30 !default;

$badge-overlay: $gray100;
$badge-opacity-light: 0.14;
Expand Down Expand Up @@ -115,16 +115,16 @@ $list-group-border-radius: 0 !default;
$label-primary-bg: $brand-color-3 !default;

//Priority
$priority-text-blocker: $white;
$priority-bg-color: $rose80;
$priority-text-blocker: $white !default;
$priority-bg-color: $rose80 !default;

// Tags
$tag-bg: $gray5;
$tag-bg-hover: $gray10;
$tag-border-radius: 4px;
$tag-bg: $gray5 !default;
$tag-bg-hover: $gray10 !default;
$tag-border-radius: 4px !default;

// TODO Temp Colors
$resource-title-color: $indigo60;
$resource-title-color: $indigo60 !default;

// Spacing
$spacer-size: 8px;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
border: none;

&:hover {
background-color: $indigo5;
background-color: $revskyblue1;
box-shadow: none !important;
}

Expand Down
59 changes: 56 additions & 3 deletions frontend/amundsen_application/static/js/config/config-custom.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This file should be used to add new config variables or overwrite defaults from config-default.ts

import { AppConfigCustom } from './config-types';
import { AppConfigCustom, BadgeStyle } from './config-types';

const configCustom: AppConfigCustom = {
browse: {
Expand All @@ -19,7 +19,7 @@ const configCustom: AppConfigCustom = {
enabled: false,
},
indexUsers: {
enabled: false,
enabled: true,
},
indexFeatures: {
enabled: false,
Expand All @@ -34,7 +34,60 @@ const configCustom: AppConfigCustom = {
inputHint: '',
},
},
productTour: {},
announcements: {
enabled: true,
},
tableProfile: {
isBeta: false,
isExploreEnabled: true,
exploreUrlGenerator: (
database: string,
cluster: string,
schema: string,
table: string
) =>
`https://metabase.revolutlabs.com/dashboard/3366?schema=${schema}&table_name=${table}`,
},
tableLineage: {
iconPath: '/static/images/metabase.svg',
isBeta: true,
externalEnabled: true,
inAppListEnabled: true,
inAppPageEnabled: true,
urlGenerator: (
database: string,
cluster: string,
schema: string,
table: string
) =>
`https://metabase.revolutlabs.com/dashboard/6780?schema_name=${schema}&table_name=${table}`,
},
badges: {
deprecated: {
style: BadgeStyle.DEFAULT,
displayName: 'Alpha',
},
'partition column': {
style: BadgeStyle.DEFAULT,
displayName: 'Partition Column',
},
sensitive: {
style: BadgeStyle.DEFAULT,
displayName: 'Sensitive',
},
confidential: {
style: BadgeStyle.DEFAULT,
displayName: 'Confidential',
},
critical: {
style: BadgeStyle.PRIMARY,
displayName: 'Critical',
},
golden: {
style: BadgeStyle.SUCCESS,
displayName: 'Golden',
},
},
};

export default configCustom;
Loading