Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On recent nix versions, we need to have the flakes experimental feature enabled. #31

Merged
merged 1 commit into from
Dec 5, 2023
Merged

On recent nix versions, we need to have the flakes experimental feature enabled. #31

merged 1 commit into from
Dec 5, 2023

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Nov 23, 2023

No description provided.

@r-vdp
Copy link
Contributor Author

r-vdp commented Dec 4, 2023

@rgri any change of getting a merge on this one?

@rgri
Copy link
Owner

rgri commented Dec 4, 2023 •
edited
Loading

Hi @r-vdp ! Sorry for the radio silence. Yeah, I added something similar to this on the recursion branch, but I can merge this PR too.

On newer versions of nix, the tex2nix binary doesn't work without your change, right?

@rgri
Copy link
Owner

rgri commented Dec 4, 2023 •
edited
Loading

Also, please change the name of your commit to be more concise, to match this project's conventions. Sorry if that's a nitpick.

@Mic92
Copy link
Collaborator

Mic92 commented Dec 5, 2023

What are the projects conventions?

@rgri
Copy link
Owner

rgri commented Dec 5, 2023

I was just thinking it might be nice to have a shorter phrase. It's not that big of a deal. Will merge!

@rgri rgri merged commit 075e36c into rgri:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-vdp @rgri @Mic92