Maven project mock test + setuptools test buff (fix #331 #375) #356
Conversation
| self.base.sack = self.base.load_dnf_sack() | ||
| self.base.load_plugins() | ||
| self.base.load_project_from_url( | ||
| r"https://github.com/citerus/dddsample-core/archive/master.zip") |
There was a problem hiding this comment.
we should specify the commit hash from which is the zip from. Otherwise if the project is change in the upstream, our tests would fail.
There was a problem hiding this comment.
Yes but there is yet another problem so it might change again.
LukasSlouka
force-pushed
the
master
branch
4 times, most recently
from
1809e89
to
07f664f
Compare
|
I updated plugin to remove artifacts that are most likely not available in |
|
|
||
| MOCK_ERR_DEP = re.compile(r"Error: No Package found for (.*)") | ||
|
|
||
| def mock_recover(self, log, spec): |
There was a problem hiding this comment.
If we fix #372 and you ensure that you always add into the BuildRequires the packages that exists (are in DNF sack) we don;t have to do this hack.
|
We have added rpm macros support (#285). Try to do it without RPM macro - it does not have to be packaged perfectly according to Fedora packaging policy now. |
LukasSlouka
force-pushed
the
master
branch
7 times, most recently
from
bf397c1
to
0184950
Compare
LukasSlouka
changed the title
|
Tests are passing + coverage of setuptools is now 100% (was 78%) |
| @@ -20,7 +20,7 @@ install: | |||
| before_script: | |||
| - docker run -i --privileged -d -v $HOME/build/$TRAVIS_REPO_SLUG:$HOME/build/$TRAVIS_REPO_SLUG --name test_fedora fedora:23 bash | |||
| - tito build --test --srpm && cp /tmp/tito/*.src.rpm . | |||
| - docker exec -i test_fedora bash -c "dnf install -y python-copr mock libsolv-devel make gcc gcc-c++ python3-dnf python-devel 'dnf-command(builddep)'; dnf builddep -y $HOME/build/$TRAVIS_REPO_SLUG/rpg.spec" | |||
| - docker exec -i test_fedora bash -c "dnf install -y python-copr mock libsolv-devel make maven-local xz-java gcc gcc-c++ python3-dnf python-devel 'dnf-command(builddep)'; dnf builddep -y $HOME/build/$TRAVIS_REPO_SLUG/rpg.spec" | |||
There was a problem hiding this comment.
shouldn't be maven-local and xz-java Requires in %package plugin-maven inside rpg.spec?
There was a problem hiding this comment.
Well those are needed for test to pass, not necessarily for plugin to function correctly. Although there could be discussion about maven-local because without it no maven project can be build using the plugin. Anyway I was not sure whether it should be part of the specfile or not.
|
38972ce merged, thanks |
LukasSlouka
force-pushed
the
master
branch
3 times, most recently
from
54d1c09
to
1595977
Compare
|
Merged, thanks |
No description provided.