Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Commit

Permalink
SSL Improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
Ricardo Pereira committed Mar 4, 2016
1 parent cc2e362 commit 026a5cb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion .gitignore
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
.idea/
vendor/
1 change: 1 addition & 0 deletions src/Common/Curl.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ public function send($url, array $params = array())
CURLOPT_RETURNTRANSFER => true,
CURLOPT_SSL_VERIFYPEER => true,
CURLOPT_SSL_VERIFYHOST => 2,
CURLOPT_SSL_CIPHER_LIST => 'TLSv1',
CURLOPT_CAINFO => dirname(__DIR__) . '/Certificates/rootca.pem',
CURLOPT_USERAGENT => 'TwitterOAuth for v1.1 API (https://github.com/ricardoper/TwitterOAuth)',

Expand Down

5 comments on commit 026a5cb

@patrickconroy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was kind of a surprising change, our server didn't have this running so all the curls failed.
Can you please put on your README that this cipher is required? If people don't have it they'll get empty responses. Thanks.

@ricardoper
Copy link
Owner

@ricardoper ricardoper commented on 026a5cb Mar 10, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoper
Copy link
Owner

@ricardoper ricardoper commented on 026a5cb Mar 10, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoper
Copy link
Owner

@ricardoper ricardoper commented on 026a5cb Mar 30, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickconroy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ricardo!

Please sign in to comment.