fix: macos is now platform specific #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it looks like with the latest 0.10.0 release, neovim is publishing macos-arm or macos-x86_64 versions only
|
Wouldn't this need to check for versions below 0.10 and still use the old logic? |
|
Possibly, I thought the plugin was version released but if we'd prefer that approach, sure happy to make that change =] |
If the version is less than 0.10.x we will want to use the old platform of just `macos` rather than split based on arch
|
I've implemented the check for version, testing upgrading to |
|
Working here. Thank you for that. Hopefully it gets merged in soon. If anyoone can't wait: |
richin13
reviewed
May 17, 2024
|
Thank you @rm-kierancoker |
|
Apologies for the formatting, not entirely sure how i didn't recognise it was so massively different 😅 Thanks for merging and making this plugin ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like with the latest 0.10.0 release, neovim is publishing macos-arm or macos-x86_64 versions only
relates to issue #21