Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings screen UI tests #31

Merged

Conversation

yan-yangyang
Copy link
Collaborator

@yan-yangyang yan-yangyang commented May 11, 2024

Description

This PR adds the following test cases:

  1. Wide notation dropdown item should exist, should be enable, and should have click action.
  2. Wide notation dropdown menu should display after Wide notation dropdown item is clicked.
  3. All wide notation dropdown menu items should display after Wide notation dropdown item is clicked.
  4. Add space after notation item should exist, should be enabled, and should have click action.
  5. Auto space switch should exist, should be enabled, and should have click action.
  6. Auto space switch value should be true in initial state.
  7. Auto space switch value should be false after it is clicked.
  8. Vibrate on tap should exist, should be enabled, and should have click action.
  9. Vibrate on tap switch should exist, should be enabled, and should have click action.
  10. Vibrate On Tap Switch value should be true in initial state.
  11. Vibrate On Tap Switch value should be false after it is clicked.
  12. Version should exist, should be enabled, and should have click action.

How to verify

  1. All test cases should pass.
  2. CI pipeline should pass.

Screenshots / Videos

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 45.67%. Comparing base (acecabc) to head (c6eb280).

Files Patch % Lines
...d/settings/ui/AddSpaceBetweenNotationSwitchItem.kt 75.00% 0 Missing and 1 partial ⚠️
...hushkeyboard/settings/ui/VibrateOnTapSwitchItem.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   44.46%   45.67%   +1.21%     
==========================================
  Files          36       36              
  Lines         686      694       +8     
  Branches      172      172              
==========================================
+ Hits          305      317      +12     
+ Misses        303      298       -5     
- Partials       78       79       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricky9667 ricky9667 self-requested a review May 13, 2024 05:13
Copy link
Owner

@ricky9667 ricky9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please help me resolve the comments 😎

Copy link
Owner

@ricky9667 ricky9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you!

@yan-yangyang yan-yangyang merged commit 36a253e into ricky9667:master May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants