Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard view second row keys UI tests #32

Merged
merged 2 commits into from
May 15, 2024

Conversation

fakiis
Copy link
Contributor

@fakiis fakiis commented May 14, 2024

Description

This PR adds the following test cases:

Second row key should exist, should be enabled, and should have click action.
Second row key should show ' notation after clicking counter clockwise button.
Second row key should show correct turn degree after clicking turn degree button.

How to verify

All test cases should pass.
CI pipeline should pass.

Screenshots / Videos

N/A

add second row key button test case
add turn degree test cases
add second row key counter clockwise button test case
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.67%. Comparing base (36a253e) to head (2968413).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files          36       36           
  Lines         694      694           
  Branches      172      172           
=======================================
  Hits          317      317           
  Misses        299      299           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ricky9667 ricky9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ricky9667 ricky9667 merged commit 98120af into ricky9667:master May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants