Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type-safe compose navigation #43

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Conversation

ricky9667
Copy link
Owner

Description

This PR migrates the usage of navigation-compose, in order to use type safe navigation in the future.
The implementation refers to Type safety in Kotlin DSL and Navigation Compose, uses beta version 2.8.0-beta06, which will be replaced with the 2.8.0 stable version when it is released.

How to verify

  1. The navigation to HomeScreen and SettingsScreen works as is.

Screenshots / Videos

N/A

@ricky9667 ricky9667 added the enhancement Developer enhancements or upgrades label Jul 28, 2024
@ricky9667 ricky9667 self-assigned this Jul 28, 2024
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.74%. Comparing base (c9b3cb8) to head (e4be51a).

Files Patch % Lines
.../java/com/rickyhu/hushkeyboard/main/MainNavHost.kt 0.00% 12 Missing ⚠️
...main/java/com/rickyhu/hushkeyboard/main/MainApp.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   45.67%   45.74%   +0.06%     
==========================================
  Files          36       34       -2     
  Lines         694      693       -1     
  Branches      172      172              
==========================================
  Hits          317      317              
+ Misses        299      298       -1     
  Partials       78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricky9667 ricky9667 merged commit 2472714 into master Jul 28, 2024
2 of 3 checks passed
@ricky9667 ricky9667 deleted the migrate-compose-navigation-usage branch October 28, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Developer enhancements or upgrades
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant