add *ViewModel -> *View resolution as fallback #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add FreshViewModelMapper for fallback type mapping add FindPageModelMapper() to FreshPageModelResolver to decide (once!) which of the conventions and mappers should be used add backing field _pageModelMapper to PageModelMapper property and _isPageModelFound field to prevent overwriting the user's instance if she set a custom IFreshPageModelMapper
|
my take on this issue. note: users still can NOT mix both conventions. but why should they? |
|
I think we should discuss this on a single place #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add FreshViewModelMapper for fallback type mapping
add FindPageModelMapper() to FreshPageModelResolver to decide (once!) which of the conventions and mappers should be used
add backing field _pageModelMapper to PageModelMapper property and _isPageModelFound field to prevent overwriting the user's instance if she set a custom IFreshPageModelMapper