Skip to content

fix: show aggregation errors in Chart.svelte instead of an infinite spinner - #9838

Open
eminemead wants to merge 1 commit into
rilldata:mainfrom
eminemead:xiaofei.yin/fix-chart-error-spinner
Open

fix: show aggregation errors in Chart.svelte instead of an infinite spinner#9838
eminemead wants to merge 1 commit into
rilldata:mainfrom
eminemead:xiaofei.yin/fix-chart-error-spinner

Conversation

@eminemead

Copy link
Copy Markdown
  • Failed aggregations left the chart on an infinite diamond spinner.
  • Chart.svelte checked isFetching before the query error, so a failed request never left the loading state.
  • Render the aggregation error first; keep the spinner only when there is no error.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

Chart.svelte checked isFetching before the query error, so a failed fill-missing aggregation never left the diamond.
@nishantmonu51 nishantmonu51 added Type:Bug Something isn't working Area:Dashboard Size:M Medium change: 100-499 lines labels Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area:Dashboard Size:M Medium change: 100-499 lines Type:Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants