Skip to content

fix: inherit explore default timezone in chat charts without time_zone - #9839

Open
eminemead wants to merge 1 commit into
rilldata:mainfrom
eminemead:xiaofei.yin/fix-chart-timezone-inherit
Open

fix: inherit explore default timezone in chat charts without time_zone#9839
eminemead wants to merge 1 commit into
rilldata:mainfrom
eminemead:xiaofei.yin/fix-chart-timezone-inherit

Conversation

@eminemead

Copy link
Copy Markdown
  • Chat charts whose spec omits time_zone were always binned in UTC, so day grains did not match the explore default timezone.
  • ChartBlock now resolves timezone the same way dashboards do: explicit spec time_zone, else the explore defaultPreset.timezone / first timeZones entry, else UTC.
  • getDefaultTimeZone honors defaultPreset.timezone first. An explicit spec zone stays authoritative.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

Explain charts omit time_zone and were binned in UTC. Resolve the same explore default as dashboards, keeping an explicit spec zone authoritative and falling back to UTC when no explore is available.
@nishantmonu51 nishantmonu51 added Type:Bug Something isn't working Area:Time Size:M Medium change: 100-499 lines labels Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area:Time Size:M Medium change: 100-499 lines Type:Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants