#14: support exporting metrics from Prometheus CollectorRegistry, add… #17

devromik · 2022-07-26T10:59:44Z

Support exporting metrics from Prometheus CollectorRegistry, add PrometheusInstanceSamplesProviderBuilder, add contributors to pom.xml.

… PrometheusInstanceSamplesProviderBuilder, add contributors to pom.xml

...in/java/com/ringcentral/platform/metrics/reporters/prometheus/PrometheusMetricsExporter.java

...ava/com/ringcentral/platform/metrics/reporters/prometheus/PrometheusMetricsExporterTest.java

mairovichaa · 2022-07-28T13:36:27Z

@devromik
What do you think about splitting of single test methods into multiple smaller ones?
Now it's difficult to understand what exactly test method checks.
I hope that the split will allow to add more descriptive names/description, which could contain preconditions and expected outcome.

Example of test classes I mean:

PrometheusMetricsExporterTest
PrometheusInstanceSampleTest
PrometheusSampleMakerTest
SimpleCollectorRegistryPrometheusInstanceSamplesProviderTest

...s/prometheus/collectorRegistry/SimpleCollectorRegistryPrometheusInstanceSamplesProvider.java

...java/com/ringcentral/platform/metrics/samples/reporters/PrometheusMetricsExporterSample.java

devromik · 2022-07-28T17:02:15Z

@devromik What do you think about splitting of single test methods into multiple smaller ones? Now it's difficult to understand what exactly test method checks. I hope that the split will allow to add more descriptive names/description, which could contain preconditions and expected outcome.

Example of test classes I mean:

PrometheusMetricsExporterTest

PrometheusInstanceSampleTest

PrometheusSampleMakerTest

SimpleCollectorRegistryPrometheusInstanceSamplesProviderTest

Created a task: #19

#14: support exporting metrics from Prometheus CollectorRegistry, add…

ededf31

… PrometheusInstanceSamplesProviderBuilder, add contributors to pom.xml

devromik requested review from ikurovsky and mairovichaa July 26, 2022 10:59