Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add ruff check #538

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

[CI] Add ruff check #538

wants to merge 6 commits into from

Conversation

trdthg
Copy link
Contributor

@trdthg trdthg commented Oct 21, 2024

resolve part of #525

Description

Currently, this PR includes the following content

@jordancarlin
Copy link
Contributor

Before adding this to CI it should probably be added to the documentation. Otherwise many people contributing will not be aware of it and will not format their code properly which will cause CI to fail. It might also make sense to have an easy way for people who don't already have it installed to run ruff locally, maybe using pre-commit.

@UmerShahidengr
Copy link
Collaborator

This is a large PR, changing plugins, riscv-isac source code, adding new things in the installation guide, updating CI. All of these things have to be documented first, otherwise we will not be able to achieve good code formatting and CI will keep failing.

@trdthg
Copy link
Contributor Author

trdthg commented Oct 21, 2024

maybe using pre-commit; All of these things have to be documented first

Agree, I'm working on that, maybe added to CONTRIBUTION.md

At the same time, I noticed that because many places in the code use eval(), some import * still need to be retained, I am also checking this part.

This PR(include ci) does not perform any formatting(may be a few small places that I modified casually); the modifications are just to resolve lint errors or warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants