Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mcontrol6 to support version 1.0 #1667

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rtwfroody
Copy link
Contributor

Functionally this means tinfo is updated to bump the version, and mcontrol6 loses the timing bit and now has hit0 and hit1 bits to describe in detail when a trigger was hit.

In anticipation of updating the mcontrol6 version, where these details
matter.
Just to keep things cleaner.
The new semantics are that the hardware gets to decide what the timing
is, and the debugger has no input on it. This implements that, but still
using the old bit encodings. That's still valid since all trigger
registers are WARL.
Functionally this means tinfo is updated to bump the version, and
mcontrol6 loses the timing bit and now has hit0 and hit1 bits to
describe in detail when a trigger was hit.

This requires a new debug_defines, generated by the debug spec.
@rtwfroody
Copy link
Contributor Author

This isn't ready for spike maintainer review yet, but I want it to be public so I can run it by someone else.

@YenHaoChen
Copy link
Collaborator

Sorry for this. There is an approved but not merged PR for mcontrol6.hit0/hit1.
#1257

@rtwfroody
Copy link
Contributor Author

@YenHaoChen, looks like spike doesn't implement tcontrol mte/mpte. Are you interested in implementing that or should I do it?

@YenHaoChen
Copy link
Collaborator

@rtwfroody ,

I created a PR for the tcontrol. (#1688)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants