Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split hinval.vvma and hinval.gvma from rv_svinval to rv_svinval_h #297

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

huxuan0307
Copy link
Contributor

Because hinval.vvma and hinval.gvma can only be used legally when both Svinval and H extensions are supported, move them out from rv_svinval to rv_svinval_h.

Because hinval.vvma and hinval.gvma can only be used legally when both Svinval and H
extensions are supported, move them out from rv_svinval to rv_svinval_h.
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.95%. Comparing base (6a1be96) to head (c184fb8).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
parse.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (6a1be96) and HEAD (c184fb8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6a1be96) HEAD (c184fb8)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #297       +/-   ##
===========================================
- Coverage   92.32%   31.95%   -60.38%     
===========================================
  Files           3        3               
  Lines         691      679       -12     
===========================================
- Hits          638      217      -421     
- Misses         53      462      +409     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aswaterman
Copy link
Member

CI is failing with the below message. Please fix it and let me know when it's time to merge.

Run coverage run ./parse.py -c -chisel -sverilog -rust -latex -spinalhdl -go "rv*" "unratified/rv*"
INFO:: encoding.out.h generated successfully
INFO:: inst.chisel generated successfully
INFO:: inst.spinalhdl generated successfully
INFO:: inst.sverilog generated successfully
INFO:: inst.rs generated successfully
package command-line-arguments
	inst.go:4:[8](https://github.com/riscv/riscv-opcodes/actions/runs/11252195557/job/31378840536?pr=297#step:6:9): use of internal package cmd/internal/obj not allowed
INFO:: inst.go generated successfully
INFO:: instr-table.tex generated successfully
ERROR:: in make_ext_latex_table: Instruction: hinval_vvma not found in instr_dict
Running with args : ['./parse.py', '-c', '-chisel', '-sverilog', '-rust', '-latex', '-spinalhdl', '-go', 'rv*', 'unratified/rv*']
Extensions selected : ['rv*', 'unratified/rv*']
Error: Process completed with exit code 1.

parse.py Outdated Show resolved Hide resolved
Signed-off-by: Jay Dev Jha <jaydev.neuroscitech@gmail.com>
@IIITM-Jay
Copy link
Member

IIITM-Jay commented Oct 11, 2024

@aswaterman, I took the liberty to rectify the issue encountered here. Could you please review it once.

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for digging into it.

@aswaterman aswaterman merged commit 8ab52af into riscv:master Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants