-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split hinval.vvma and hinval.gvma from rv_svinval to rv_svinval_h #297
Conversation
Because hinval.vvma and hinval.gvma can only be used legally when both Svinval and H extensions are supported, move them out from rv_svinval to rv_svinval_h.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
===========================================
- Coverage 92.32% 31.95% -60.38%
===========================================
Files 3 3
Lines 691 679 -12
===========================================
- Hits 638 217 -421
- Misses 53 462 +409 ☔ View full report in Codecov by Sentry. |
CI is failing with the below message. Please fix it and let me know when it's time to merge.
|
Signed-off-by: Jay Dev Jha <jaydev.neuroscitech@gmail.com>
@aswaterman, I took the liberty to rectify the issue encountered here. Could you please review it once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for digging into it.
Because hinval.vvma and hinval.gvma can only be used legally when both Svinval and H extensions are supported, move them out from rv_svinval to rv_svinval_h.