-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proc Type API - Groove's Worst Mistake #513
base: master
Are you sure you want to change the base?
Proc Type API - Groove's Worst Mistake #513
Conversation
switch underlying data from bool[] to byte[], add GetRaw versions of public mask access
Removed draft status because most of the initial issues have been addressed. Deployment is still a concern. Testing looks good so far; if anyone has time to run some tests of their own I'd appreciate it. |
Only small changes need to be done inside the .toml files for this to correctly release on thunderstore from the github action |
|
||
[[build.copy]] | ||
source = "./ReleaseOutput" | ||
target = "./plugins/R2API.ProcType" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing another entry for the patcher afaik
[[build.copy]]
source = "./ReleaseOutput/PATCHER_DLL"
target = "./patchers/"
outdir = "./build" | ||
|
||
[[build.copy]] | ||
source = "./ReleaseOutput" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source = "./ReleaseOutput/PLUGIN_DLL.dll"
instead of the whole folder
An implementation of custom Proc Types that is not limited by the vanilla mask size. Patches a field onto
RoR2.ProcChainMask
to store modded proc chain mask information.This is a draft because documentation/readme is not complete, the implementation is still up for debate, and it would currently not deploy properly (hoping someone else can deal with this).
Main Components are:
ReserveProcType
and theAddModdedProc
,RemoveModdedProc
, andHasModdedProc
extensions which mirrorProcChainMask.AddProc
,ProcChainMask.RemoveProc
, andProcChainMask.HasProc
RoR2.ProcChainMask
to hold modded data