Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract): add getSpaceByTokenId to SpaceOwner #1116

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shuhuiluo
Copy link
Contributor

Implement getSpaceByTokenId to retrieve space addresses by token ID and update corresponding tests. This enhances the SpaceOwner facet to allow querying of space addresses directly by token ID, improving data accessibility.

@giuseppecrj
Copy link
Contributor

we already have this in space factory

@shuhuiluo
Copy link
Contributor Author

we already have this in space factory

It doesn't make SpaceOwner self-contained. If someone wants to fetch the space info for all spaces, they have to get the total supply from SpaceOwner, call getSpaceByTokenId on the SpaceFactory and come back to SpaceOwner for getSpaceInfo. That's not intuitive.

Implement `getSpaceByTokenId` to retrieve space addresses by token ID and update corresponding tests. This enhances the `SpaceOwner` facet to allow querying of space addresses directly by token ID, improving data accessibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants