stream-metadata: granular space refresh #1240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-nascimento
changed the title
texuf
reviewed
Oct 15, 2024
| ? [`/space/${spaceAddress}`, `/space/${spaceAddress}/token/*`] | ||
| : target === 'image' | ||
| ? [`/space/${spaceAddress}/image`] | ||
| : [`/space/${spaceAddress}/*`] |
There was a problem hiding this comment.
for "all" will /space/${spaceAddress}/* match /space/${spaceAddress}? I am superstitious about trailing slashes.
There was a problem hiding this comment.
to include the /space/spaceAddress we could use /space/spaceAdress*
There was a problem hiding this comment.
/* only match things inside the slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close: TOWNS-12688
If you update the space name, the space member nft has a space name field, so we need to refresh both space owner nft metadata (/space/spaceAddress) and member nft (/space/spaceAddress/token/tokenId)
If you update the space image, we only need to update the /space/spaceAddress/image
The image field on the metadata for space & space member will be redirected to the right one