avoid cached scrollbacks if stream contains a renderable event #1292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client init performance tweak.
We're performing scrollbacks hoping to pick up renderable events. By skipping cached scrollbacks when the loaded miniblocks already contain a renderable event, we can return early.
Lowers the duration of
loadStreamsFromPersistence
on my machine with my user's streams from ~7500ms to ~6500ms.This logic could also be tweaked to guarantee that a stream contains a top-level renderable event.