Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contract): add convenience methods to EIP712Facet #1299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

feat(contract): add convenience methods to EIP712Facet #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/scripts/deployments/facets/DeployEIP712Facet.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {EIP712Facet} from "contracts/src/diamond/utils/cryptography/signature/EI

contract DeployEIP712Facet is FacetHelper, Deployer {
constructor() {
addSelector(EIP712Facet.DOMAIN_SEPARATOR.selector);
addSelector(EIP712Facet.nonces.selector);
addSelector(EIP712Facet.eip712Domain.selector);
}

Expand Down
8 changes: 8 additions & 0 deletions contracts/src/diamond/utils/cryptography/signature/EIP712Facet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ contract EIP712Facet is IERC5267, EIP712Base, Nonces, Facet {
__EIP712_init_unchained(name, version);
}

function DOMAIN_SEPARATOR() external view virtual returns (bytes32) {
return _domainSeparatorV4();
}

function nonces(address owner) external view returns (uint256) {
return _latestNonce(owner);
}

/// @inheritdoc IERC5267
function eip712Domain()
public
Expand Down
Loading