Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review code #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Review code #1

wants to merge 1 commit into from

Conversation

ahxar
Copy link

@ahxar ahxar commented Mar 27, 2021 •
edited
Loading

Beberapa sudah bagus, yang perlu diperhatikan:

  • Formatting nya, coba pakai ekstensi Prettier utk formatting di VS Code, kalo ga pakai VS Code sebaiknya coba pakai dulu, fiturnya lbih baik dibandingkan dengan sublime text
  • Usahakan pake Eloquent Model daripada Database Builder (DB) agar mudah dalam penggunaan relasi tabel
  • folder resource/views/* kalo bisa huruf kecil smua agar seragam, bgtu pun dengan file .blade.php nya
  • Import DB dan Uuid nya dengan benar, jangan pakai \DB, \Uuid, contohnya seperti yang saya udh perbaiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahxar