Update validation message for one_of #5130
Merged
+46
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcwatt
force-pushed
the
one-of-validation-error
branch
from
2d48289
to
0146258
Compare
alexcwatt
force-pushed
the
one-of-validation-error
branch
3 times, most recently
from
a4a1db2
to
fa62d0c
Compare
rmosolgo
reviewed
Oct 22, 2024
rmosolgo
approved these changes
Oct 24, 2024
alexcwatt
force-pushed
the
one-of-validation-error
branch
from
903785e
to
8e7cdc3
Compare
|
@rmosolgo great! I just squashed the first and last commit together and kept the middle one. You can see in GitHub UI that there were no changes in final state of this branch with the force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the error message when a
one_ofvalidation is not satisfied to be more explicit about what the issue is.Before: "{field_name} has the wrong arguments"
After: "{field_name} must include exactly one of the following arguments: a, b."
Note: PR seems to be failing due to unreliable tests. Example 1, Example 2