Avoid unnecessary copies when preparing detection inputs #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for code which needs to conditionally copy a tensor. This should be upstreamed to `rten-tensor`.
- If the image doesn't need to be padded, don't copy it - If the image doesn't need to be resized, don't do an identity resize For small inputs where both spatial dimensions are smaller than the model's input we'll need to pad but not resize. For large inputs where the opposite is true we'll need to resize but not pad. For medium inputs where one dim exceeds the corresponding model input size and the other is smaller, we'll need to do both.
robertknight
added a commit
to robertknight/rten
that referenced
this pull request
May 5, 2024
This is useful for code which needs to conditionally copy or create a tensor, and then get the results of the copying and non-copying code paths into the same type. See robertknight/ocrs#57 for a downstream solution that can be replaced by this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a copy that is sometimes redundant:
For small inputs where both spatial dimensions are smaller than the model's
input we'll need to pad but not resize. For large inputs where the opposite is
true we'll need to resize but not pad. For medium inputs where one dim exceeds
the corresponding model input size and the other is smaller, we'll need to do
both.