Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow negative indices in Gather op #47

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Allow negative indices in Gather op #47

merged 1 commit into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Allow negative indices in Gather op 

    Per the ONNX spec [1]:

> All index values are expected to be within bounds [-s, s-1] along axis of size s.

The implementation already supported negative values, only the bounds check
preceding it did not.

[1] https://onnx.ai/onnx/operators/onnx__Gather.html

Fixes #46
    @robertknight
    robertknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    573ded4 View commit details
    Browse the repository at this point in the history