Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Venusian #669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

emilgoldsmith
Copy link

I am updating venusian as at the current version it always displays this deprecation warning:

the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

but I checked and from version 2.0.0 onwards they fixed this (see https://github.com/Pylons/venusian/blob/24d1d2515972dd61ba1881fec780d658c254a612/CHANGES.rst).

I'm not familiar with the codebase so there of course could be some breakage with updating the library but in case there's not it would be great to be able to remove that deprecation warning from faust

@emilgoldsmith
Copy link
Author

Looked a bit at the typechecking error and I couldn't see how it should relate with my change, could anyone help me take a quick look ?

@forsberg
Copy link

I tried running master through travis and got the same error. The job succeeded on exactly the same source code 11 days ago, so indeed it seems unrelated.

One difference I can see in the output from the travis runs is that the mypy version install differs:

  • Job that succeeds: mypy==0.782
  • Job that fails: mypy==0.790

I can repeat the problem locally by running TOXENV=typecheck tox -r and then get rid of the problem by modifying requirements/typecheck.txt to list mypy==0.782 then rerun TOXENV=typecheck tox -r.

So I'm guessing the newer tox version either found a bug, or we need to tell mypy to ignore the typing error because it's intentional.

@forsberg
Copy link

Opened #672 for this.

@emilgoldsmith
Copy link
Author

Nice debugging, thanks for the support @forsberg

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants