Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected conditions 1827 #1865

Merged
merged 24 commits into from
Apr 14, 2024

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    5a6735c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Configuration menu
    Copy the full SHA
    583c9e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc60e23 View commit details
    Browse the repository at this point in the history
  3. Initial (working) prototype of wait for.. keyword

    Wanted to just throw out a sample test case, test application (page),
    and a working keyword. Interesting this works at a very basic level. See
    next paths for a few functionality like
    
    - instead of snake_case create method for using "space case"
    - add check for presence of method
    - add polling delay, timeout
    - ...?
    emanlove committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    2b10abf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb49c98 View commit details
    Browse the repository at this point in the history
  5. Moved previous expected condition tests out of current test suite

    These were some initial sketches for the keywords and their usage. As
    they are not working I have moved them out of the test suite.
    emanlove committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    129e9b0 View commit details
    Browse the repository at this point in the history
  6. Adding another sample tests and modifying keyword behavior

    - Added 100 millisecond polling to wait. Seems like a good default. Will
      need to decide on how to let users set this.
    - Copied dynamic_content.html making into seperate
      expected_conditions.html test page.
    - Added another sample test case
    emanlove committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    36e7da3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    48376f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. added timeout argument to keyword wait_for_expected_condition

    Added timeout atest
    yuriverweij committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3083459 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Merge pull request #3 from yuriverweij/feature/add_expected_condition…

    …s_1827
    
    added timeout argument to keyword wait_for_expected_condition
    emanlove authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    754e793 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98d8f89 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Basic working keyword for wait

    Made a few changes ..
    - Catch unknown expoected conditions and reopport an error. This can still be improved
      by adding a here are the known expected conditions as well as a "did you mean ..."
      type message
    - Brought in parser so one can use `Element To Be Clickable` instead of
      `element_to_be_clicable`. Admittedly it seems to simple and realized an issue, of case,
      as I type this.
    - Added some test cases
    emanlove committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7ad5296 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Added test case for capitals within expected condition name

    Hadn't realized I do force the expected condition ame to all lower case letters. So just needed
    to add a test case!
    emanlove committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b022031 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Added example test where expected condition expected "locator" tuple

    Some of the expected conditions expect a locator which is a tuple
    consisting of the By string [1] and the string containing the locator.
    I wanted to see what this was like. I am thinking that it would be good
    to somehow use the libraries locator strategy.
    
    Needed to also add to the test page so we had a new element after a delay.
    
    [1] https://www.selenium.dev/selenium/docs/api/py/_modules/selenium/webdriver/common/by.html#By
    emanlove committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    d23700e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    7bdca3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd05dfd View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Fix Firefox unit tests

    Made unit test compatible to both Selenium v4.17.2 and above as well as
    v4.16.0 and prior
    emanlove committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    fd751bb View commit details
    Browse the repository at this point in the history
  2. Reduced the timeout on the expected timeout within expected conditions

    The delay for the title change was 600 miliseconds while the timeout was
    0.5 seconds. I suspect this gives little time for error. The 600
    milisecond timeout was specifically choosen along with the other
    timeouts in the expected conditions tests such that any combination of
    delays would be unique. This gives us a framework to test various
    combinations. So I didn't want to change that. Noting I could simply
    swap the 600 millisecond test for the 900 millisecond tes .. which might
    be the best bet. But for now trying to reduce the timeout to 0.3
    seconds.
    emanlove committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    204ceda View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e1a4f4c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Fix acceptance tests

    emanlove committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f17f8f0 View commit details
    Browse the repository at this point in the history
  2. Append results to zip file

    This may greatly increase the archive file size which we need to simplify our matrix.
    But at least we should get some more insights into failing tests.
    emanlove committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    de1a4fb View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Configuration menu
    Copy the full SHA
    8db00db View commit details
    Browse the repository at this point in the history
  2. Upload only failed artifacts

    emanlove committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a0e241d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cc41bc1 View commit details
    Browse the repository at this point in the history