-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to run generate-conda-packages job without uploading and fix generate-conda-packages #665
Conversation
Please ignore the failure in the normal C++ job, I killed it as it is not relevant for this PR, the releant job that I triggered manually is: https://github.com/robotology/robotology-superbuild/runs/2182648284 . |
The build completed successfully for Linux ( https://github.com/robotology/robotology-superbuild/runs/2182648284 ) and is ongoing for Windows and macOS, so I think it is safe to ask for a review now. |
@@ -142,7 +142,7 @@ macro(generate_metametadata_file) | |||
endmacro() | |||
|
|||
macro(generate_conda_recipes) | |||
set(python_generation_script "${CMAKE_CURRENT_SOURCE_DIR}/conda/python/generate_conda_recipes_from_metadatadata.py") | |||
set(python_generation_script "${CMAKE_CURRENT_SOURCE_DIR}/conda/python/generate_conda_recipes_from_metametadata.py") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a curiosity, why is it called metametadata
? Curious about the two metas ;D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A conda recipe contains a file meta.yaml
that is supposed to contain metadata of the package being built (see https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html). In our case, this meta.yaml file is generated from a template (https://github.com/robotology/robotology-superbuild/blob/master/conda/recipe_template/meta.yaml) using Jinja2 template engine.
This template so is used to generate the meta.yaml
file that contains metadata, but it does so by getting the relevant info that so contains metametadata, because it is metadata about the metadata. This memetametadata file itself is generated automatically by the CMake logic of the superbuild, for more on this feel free to refer to https://github.com/robotology/robotology-superbuild/blob/master/doc/conda-recipe-generation.md#internals . Actually I noticed a typo also there.
After merging #652, I tried to run
generate-conda-packages
via workflow_dispatch and it was failing due to this:Probably some change occured doing the review that broke the build. However, this revealed the need to be able to test this github actions on PRs, but without uploading any package. For doing so, I also modified the job to have an input to the
workflow_dispatch
.The actual conda package generation should be fixed by 82d4cdb, but let's try it first.
Example of invocation of a job: