Add proof bundles - #1204
Open
0xfornax wants to merge 1 commit into
Open
Conversation
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
jshufro
reviewed
Sep 1, 2026
Comment on lines
+17
to
+34
| type ValidatorProofBundleV1 struct { | ||
| ValidatorProof ValidatorProof | ||
| SlotProof SlotProof | ||
| } | ||
|
|
||
| type FinalBalanceProofBundleV1 struct { | ||
| WithdrawalProof WithdrawalProof | ||
| ValidatorProof ValidatorProof | ||
| SlotProof SlotProof | ||
| } | ||
|
|
||
| type FinalBalanceProofBundleV2 struct { | ||
| WithdrawalProof WithdrawalProof | ||
| ValidatorProof ValidatorProof | ||
| SlotProof SlotProof | ||
| PreviousNextWithdrawalIndexProof NextWithdrawalIndexProof | ||
| ValidatorBalanceProof ValidatorBalanceProof | ||
| } |
Contributor
There was a problem hiding this comment.
Should these types have json tags? They seem like useful artifacts to be able to serialize on the network or to disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves megapool beacon proofs onto versioned, ABI-encoded proof bundles so Smart Node matches BeaconStateVerifier on v1.4.1-dev / Gloas.
Stake, notify-exit, not-exit, dissolve-with-proof, and notify final balance now take
(proofVersion, proofData)instead of separate proof structs. Call sites encodeValidatorProofBundleV1(or final-balance v1/v2) before submitting. Final-balance v2 also packs next-withdrawal-index and validator-balance proofs.