-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade backbone #1484
base: master
Are you sure you want to change the base?
Upgrade backbone #1484
Conversation
@schakrava Travis?? 😄 🎉 |
Yay I failed the first Travis build! 😛 It only checked for Ruby :( |
Hmm, my last commit is not the right way. Will probably revert it and instead insert |
Newer versions of Backbone no longer implicitly attach these to the view, so the relevant initialize functions now do so explicitly.
4eca949
to
bf3756b
Compare
@sfranzen Since upgrading backbone pretty much effects every part of the UI, can you tell us if/how you've tested this for potential regressions? |
Hello @sfranzen Thanks for the PR. I have pulled your changes and tested it on my VM but found out that the UI doesn't work as expected.
These are only a few of them and I see a lot more of them. I think it needs some more testing and fixing up. |
Thanks @priyaganti . @sfranzen, please rebase with latest master. This is an important change and I appreciate your contribution, just needs a bit more testing. good luck! |
This pr can sever to inform an updating to our backbone libs and use, post our testing branch creation. |
From: https://github.com/jashkenas/backbone/tags the latest release of Backbone (https://backbonejs.org/) is now at 1.6.0 (5th Feb 2024). Changelog: https://backbonejs.org/#changelog From which we have the main update requirement addressed in this PR, introduced in 1.1.0:
Re-iterating that this PR depends on rockstor/rockstor-jslibs#8 which proposed an update to 1.3.3 (Apr. 5, 2016) |
Depends on rockstor/rockstor-jslibs#8.