Support snapper #1491
Open
Support snapper #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Backbone versions no longer automatically set this on the object, you have to pass it to initialize().
Allows user modifications to persist.
Provides automatic pre/post snapshots for each yum transaction, just like the official plugin for zypper (SUSE systems). Related: rockstor#1432
Embeds a Backform form within our standard Bootstrap panel element. Can be used just like a Backform.Form view, because all constructor arguments are passed on to the form.
Looks a little cleaner and more appropriate to me.
This reverts commit 4eca949.
Newer versions of Backbone no longer implicitly attach these to the view, so the relevant initialize functions now do so explicitly.
Allow retrieving individual snapshots as well as full list.
This allows the collections of snapshots to be nested below their configuration name in the web API.
This is better suited to snapper than the ListCreateAPIView, since snapper's interface does not return Django models or querysets.
Configured subvolume is already returned by snapper. Return snapshot userdata as a dict because that's what SetSnapshot accepts.
Necessary to make deletions function appropriately.
It was not responding to model deletion events.
|
@sfranzen I am wondering what the status of this is since your last push? Now that 3.8.16 is out, I'd really like to catch up and looks like you put in a lot of work and certainly like to do my part here. |
|
I would like to re-visit this pr once we have our move to openSUSE 'in the can'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR early to make it easier to show/review progress on this.
Depends on rockstor/rockstor-jslibs#8 and a future request for Backform.
Fixes #1432.