Merge pull request #112 from rollbar/obf_breadcrumb

Fixed breadcrumbs not being sorted correctly in obfuscated builds
rollbar · Aug 3, 2023 · 1517290 · 1517290
2 parents 4177be3 + af0e10d
commit 1517290
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/rollbar_dart/CHANGELOG.md b/rollbar_dart/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.3.1
+
+- Fixed breadcrumbs not being processed in the right order in obfuscated builds.
+
 ## 1.3.0
 
 - The log, debug, info, warn, error and critical methods in `Rollbar` now accept any type of object including `Error`, `Exception` and `String`. Dart objects that specialize `toString()` can be also passed and they'll be converted into their string representations.

diff --git a/rollbar_dart/example/pubspec.yaml b/rollbar_dart/example/pubspec.yaml
@@ -9,7 +9,7 @@ environment:
 
 dependencies:
   logging: ^1.0.2
-  rollbar_dart: ^1.1.0
+  rollbar_dart: ^1.3.0
 
 dependency_overrides:
   rollbar_common:

diff --git a/rollbar_dart/lib/src/notifier/notifier.dart b/rollbar_dart/lib/src/notifier/notifier.dart
@@ -6,7 +6,7 @@ import 'package:rollbar_dart/rollbar_dart.dart';
 @sealed
 abstract class Notifier {
   // notifier version to be updated with each new release: [todo] automate
-  static const version = '1.3.0';
+  static const version = '1.3.1';
   static const name = 'rollbar-dart';
 
   FutureOr<Context> notify(Context state, final Event event);

diff --git a/rollbar_dart/lib/src/telemetry.dart b/rollbar_dart/lib/src/telemetry.dart
@@ -26,7 +26,7 @@ class Telemetry with Persistence<BreadcrumbRecord> implements Configurable {
       );
 
   List<Breadcrumb> breadcrumbs() => records
-      .sorted(by: #BreadcrumbRecord.timestamp)
+      .sorted(by: Symbol('${(BreadcrumbRecord).toString()}.timestamp'))
       .map((record) => jsonDecode(record.breadcrumb) as JsonMap)
       .map(Breadcrumb.fromMap)
       .toList();

diff --git a/rollbar_dart/pubspec.yaml b/rollbar_dart/pubspec.yaml
@@ -1,6 +1,6 @@
 name: rollbar_dart
 description: Connect your Dart applications to Rollbar for error reporting.
-version: 1.3.0
+version: 1.3.1
 homepage: https://www.rollbar.com
 documentation: https://docs.rollbar.com/docs/flutter#dart
 repository: https://github.com/rollbar/rollbar-flutter