Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update terraform integration documentation #381

Merged
merged 3 commits into from
Nov 6, 2023
Merged

update terraform integration documentation #381

merged 3 commits into from
Nov 6, 2023

Conversation

pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Nov 4, 2023 •
edited
Loading

Description of the change

Update integration documentation

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

ghost
ghost reviewed Nov 6, 2023
View reviewed changes
docs/resources/integration.md Outdated
resource "rollbar_integration" "webhook_integration" {
webhook {
enabled = true
url = "https://www.some-website.com"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some-website.com is a real URL. Can you change it to example.com?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ghost
ghost reviewed Nov 6, 2023
View reviewed changes
docs/resources/integration.md

This resource can manage configuration for the Slack channel. See the following api documentation for more details about the arguments with respect to the Slack channel:
This resource can manage configuration for the Slack, Webhook, Email and PagerDuty channels. See the following api documentation for more details about the arguments with respect to these channels:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the respective documentation pages too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ghost
ghost suggested changes Nov 6, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting these integration options. Can you address these 2 requests? Thanks.

ghost
ghost approved these changes Nov 6, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pawelsz-rb pawelsz-rb merged commit 2582b54 into master Nov 6, 2023
16 of 17 checks passed
@pawelsz-rb pawelsz-rb deleted the pawel/update_integration_doc branch November 6, 2023 17:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

🎉 This PR is included in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pawelsz-rb