fixed etox_basic #229
Merged
fixed etox_basic #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stitam
requested changes
Mar 25, 2020
|
Updated the PR. Why does CI concern you? Its checks passed. I'm not very familiar with CI I have to admit. |
|
changed the etox.R and the test-etox.R files as discussed. Left the improved code out-commented there to continue work in the future. Don't know why CI fails. |
stitam
approved these changes
Mar 26, 2020
|
It failed because I didn't approve the changes, also because there were some conflicts in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed
etox_basic()issue addressed in #227changed output of etox_basic
added
cas.etox_basic()method to R/extractors.RPR task list:
devtools::document()