Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toggle option to Topic-type commands #66

Open
wants to merge 4 commits into
base: foxy-devel
Choose a base branch
from

Conversation

AndyZe
Copy link
Contributor

@AndyZe AndyZe commented Mar 9, 2021

This builds on PR #65.

It adds a toggle_buttons option for Topic-type commands. This is an alternative to the deadman button, or you can actually have BOTH at the same time.

@bmagyar
Copy link
Member

bmagyar commented Mar 21, 2021

Please rebase this on latest foxy-devel and add a test. Check the tests folder, it is fairly simple to add a new one.

Can you please also add some sort of docs explaining how the toggle button is expected to work? I'd like to avoid people getting confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants