Fix prettier==3 and eslint-plugin-prettier==4 incompatibility #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
requested review from
gbiggs and
MichaelOrlov
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 8 8
Lines 186 186
Branches 22 22
=======================================
Hits 172 172
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
christophebedard
force-pushed
the
christophebedard/update-dist-file
branch
from
b83c0b4
to
35ad5d8
Compare
christophebedard
changed the title
|
This fixes the linter job, so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting this error when running
npm run lint:Apparently,
prettier==3andeslint-plugin-prettier==4are not compatible; we need to bump toeslint-plugin-prettier==5: https://stackoverflow.com/a/76625797/6476709.Also, regenerate the dist file.