Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] re-introduce addDiagnostics to aggregator #143

Open
norro opened this issue Jun 16, 2020 · 1 comment
Open

[ros2] re-introduce addDiagnostics to aggregator #143

norro opened this issue Jun 16, 2020 · 1 comment
Labels
enhancement This tackles a new feature of the code (and not a bug) ros2 PR tackling a ROS2 branch

Comments

@norro
Copy link
Collaborator

norro commented Jun 16, 2020

During migration of the diagnostics aggregator to ROS 2, the addDiagnostics feature was kicked out. This was mainly done due to its dependency on bond.

Former documentation of this feature was: "Service request callback for addition of diagnostics. Creates a bond between the calling node and the aggregator, and loads information about new diagnostics into added_analyzers_, keeping track of the formed bond in bonds_."

Re-introduce this feature, but check if heartbeat can be handled with rmw mechanisms instead of bond.

@Karsten1987
Copy link
Contributor

looking at RMW, I think the liveliness assertion might be a good entry point for this:
https://github.com/ros2/rmw/blob/master/rmw/include/rmw/rmw.h#L490-L512

Not sure how well supported it is by all RMWs, but we could think of making it optional.

@Karsten1987 Karsten1987 added the ros2 PR tackling a ROS2 branch label Jun 16, 2020
@Karsten1987 Karsten1987 added the enhancement This tackles a new feature of the code (and not a bug) label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This tackles a new feature of the code (and not a bug) ros2 PR tackling a ROS2 branch
Projects
None yet
Development

No branches or pull requests

2 participants